suppress duplicate reports with -c/-C and -q/-Q

If fping receives a duplicate Echo Reply packet, it reports
this.  This report was suppressed for loop mode, and for
other operating modes where each receive event is reported.
Now, this duplicate report is also suppressed when in count
mode with options -q, --quiet or -Q, --squiet.

This addresses GitHub issue #389.

diff --git a/CHANGELOG.md b/CHANGELOG.md
index b4039549ac50fdf686d1d01a111446c28209d502..0e6338c56cb417416a90a11944d6671450bb9716 100644 (file)
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,7 +7,6 @@ Next
   @JoshIPT, @sebast-gsnw and @auerswal)
 - The -g, --generate option now also supports IPv6 addresses (#376,
   thanks @auerswal)
-
 - New option --seqmap-timeout to control the time after which sequence numbers
   can be used again (#388, thanks @auerswal)
 
@@ -16,17 +15,15 @@ Next
 - Fix OpenBSD warning sprintf() is often misused, please use snprintf() (#394, thanks @gsnw-sebast)
 - Fix fallback to SO\_TIMESTAMP if SO\_TIMESTAMPNS is not available (#375,
   thanks @auerswal)
-
 - When reading target names from file or standard input, lines longer
   than the static buffer are no longer interpreted as more than one line
   (#378, thanks @auerswal)
-
 - Typo fix in error message when SO\_BINDTODEVICE fails
-
 - Options --print-tos and --print-ttl now also work for IPv6, and no
   longer require privileges (#384, thanks @auerswal)
-
 - Report received ICMPv6 error messages (#391, thanks @auerswal)
+- Suppress duplicate reports in count mode with -q, --quiet or -Q, --squiet
+  (#392, thanks @gsnw-sebast and @auerswal)
 
 fping 5.3 (2025-01-02)
 ======================

diff --git a/src/fping.c b/src/fping.c
index 00cfdb4ff93c3f6999352c0e891a898f579e69d7..ae207b426196feb7f7c8473a704d6a34a7dca037 100644 (file)
--- a/src/fping.c
+++ b/src/fping.c
@@ -3119,7 +3119,7 @@ int wait_for_reply(int64_t wait_time)
     }
 
     /* discard duplicates */
-    if (!loop_flag && h->resp_times[this_count] >= 0) {
+    if (!loop_flag && !(count_flag && quiet_flag) && h->resp_times[this_count] >= 0) {
         if (!per_recv_flag) {
             fprintf(stderr, "%s : duplicate for [%d], %d bytes, %s ms",
                 h->host, this_count, result, sprint_tm(this_reply));